diff options
author | plf <plf@google.com> | 2018-06-26 02:54:32 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-06-26 02:55:39 -0700 |
commit | b38098e1f8d9d78528f8f5a61fd76d5cce601a1c (patch) | |
tree | b5d6a3989cf6ee145ae620986ef7d0924bb20a33 /src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java | |
parent | d88eee849d53ef71afc85f858b67af3d276d98fa (diff) |
C++: Remove call to initializeCcCompilationContext.
To get a CcCompilationInfo instance from Skylark it will either have to be
through its constructor (not yet fully implemented) which will not schedule any
actions or through a call to compile() which does schedule actions.
RELNOTES:none
PiperOrigin-RevId: 202099841
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java index 149e5bfb29..820879e69f 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java @@ -923,10 +923,8 @@ public final class CcCompilationHelper { /** * Create {@code CcCompilationContext} for cc compile action from generated inputs. - * - * <p>TODO(plf): Try to pull out CcCompilationContext building out of this class. */ - public CcCompilationContext initializeCcCompilationContext() { + private CcCompilationContext initializeCcCompilationContext() { CcCompilationContext.Builder ccCompilationContextBuilder = new CcCompilationContext.Builder(ruleContext); |