aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2015-08-21 19:50:36 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-08-24 14:02:31 +0000
commitb9f89e6542c7bed311d4167adae076be5472bbd6 (patch)
tree0e7a490da088f164392a3d0b9015bd22ee4cf443 /src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java
parentc466e6b3c429cd58ebaa0af16e7c2fcb615f973b (diff)
Add the implicit output of unstripped binary for Launcher-enabled java_binary.
Use stripped launcher when Fission is enabled. -- MOS_MIGRATED_REVID=101244628
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java29
1 files changed, 1 insertions, 28 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java
index ad50ad4131..1dde2a44fd 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java
@@ -266,7 +266,7 @@ public abstract class CcBinary implements RuleConfiguredTargetFactory {
// Create the stripped binary, but don't add it to filesToBuild; it's only built when requested.
Artifact strippedFile = ruleContext.getImplicitOutputArtifact(
CppRuleClasses.CC_BINARY_STRIPPED);
- createStripAction(ruleContext, cppConfiguration, executable, strippedFile);
+ CppHelper.createStripAction(ruleContext, cppConfiguration, executable, strippedFile);
DwoArtifactsCollector dwoArtifacts =
collectTransitiveDwoArtifacts(ruleContext, ccCompilationOutputs, linkStaticness);
@@ -331,33 +331,6 @@ public abstract class CcBinary implements RuleConfiguredTargetFactory {
}
/**
- * Creates an action to strip an executable.
- */
- private static void createStripAction(RuleContext context,
- CppConfiguration cppConfiguration, Artifact input, Artifact output) {
- context.registerAction(new SpawnAction.Builder()
- .addInput(input)
- .addTransitiveInputs(CppHelper.getToolchain(context).getStrip())
- .addOutput(output)
- .useDefaultShellEnvironment()
- .setExecutable(cppConfiguration.getStripExecutable())
- .addArguments("-S", "-p", "-o", output.getExecPathString())
- .addArguments("-R", ".gnu.switches.text.quote_paths")
- .addArguments("-R", ".gnu.switches.text.bracket_paths")
- .addArguments("-R", ".gnu.switches.text.system_paths")
- .addArguments("-R", ".gnu.switches.text.cpp_defines")
- .addArguments("-R", ".gnu.switches.text.cpp_includes")
- .addArguments("-R", ".gnu.switches.text.cl_args")
- .addArguments("-R", ".gnu.switches.text.lipo_info")
- .addArguments("-R", ".gnu.switches.text.annotation")
- .addArguments(cppConfiguration.getStripOpts())
- .addArgument(input.getExecPathString())
- .setProgressMessage("Stripping " + output.prettyPrint() + " for " + context.getLabel())
- .setMnemonic("CcStrip")
- .build(context));
- }
-
- /**
* Given 'temps', traverse this target and its dependencies and collect up all
* the object files, libraries, linker options, linkstamps attributes and linker scripts.
*/