diff options
author | Cal Peyser <cpeyser@google.com> | 2016-07-12 18:22:13 +0000 |
---|---|---|
committer | Kristina Chodorow <kchodorow@google.com> | 2016-07-13 11:15:40 +0000 |
commit | 5234eed84d845cda522256ad9674ec0a7076f7be (patch) | |
tree | 6d8d276cc0146e02256aa9ce2b10afa56f3fd2b8 /src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java | |
parent | bc08ee7963816bbd361cc3043dec54f4e58a4bdb (diff) |
Extract CppLinkAction.Builder to its own top level class.
--
MOS_MIGRATED_REVID=127221256
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java | 25 |
1 files changed, 15 insertions, 10 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java index 78bc18c9f5..f83158feb5 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java @@ -192,7 +192,7 @@ public abstract class CcBinary implements RuleConfiguredTargetFactory { } Artifact binary = ruleContext.getPackageRelativeArtifact( binaryPath, ruleContext.getConfiguration().getBinDirectory()); - CppLinkAction.Builder linkActionBuilder = + CppLinkActionBuilder linkActionBuilder = determineLinkerArguments( ruleContext, common, @@ -380,18 +380,23 @@ public abstract class CcBinary implements RuleConfiguredTargetFactory { } /** - * Given 'temps', traverse this target and its dependencies and collect up all - * the object files, libraries, linker options, linkstamps attributes and linker scripts. + * Given 'temps', traverse this target and its dependencies and collect up all the object files, + * libraries, linker options, linkstamps attributes and linker scripts. */ - private static CppLinkAction.Builder determineLinkerArguments(RuleContext context, - CcCommon common, PrecompiledFiles precompiledFiles, + private static CppLinkActionBuilder determineLinkerArguments( + RuleContext context, + CcCommon common, + PrecompiledFiles precompiledFiles, CcCompilationOutputs compilationOutputs, ImmutableSet<Artifact> compilationPrerequisites, - boolean fake, Artifact binary, - LinkStaticness linkStaticness, List<String> linkopts) { - CppLinkAction.Builder builder = new CppLinkAction.Builder(context, binary) - .setCrosstoolInputs(CppHelper.getToolchain(context).getLink()) - .addNonLibraryInputs(compilationPrerequisites); + boolean fake, + Artifact binary, + LinkStaticness linkStaticness, + List<String> linkopts) { + CppLinkActionBuilder builder = + new CppLinkActionBuilder(context, binary) + .setCrosstoolInputs(CppHelper.getToolchain(context).getLink()) + .addNonLibraryInputs(compilationPrerequisites); // Determine the object files to link in. boolean usePic = CppHelper.usePic(context, !isLinkShared(context)); |