diff options
author | 2017-10-13 09:27:10 +0200 | |
---|---|---|
committer | 2017-10-13 13:53:25 +0200 | |
commit | 80a34dc97799961201e6dce20fd58dd08022c032 (patch) | |
tree | 0e3820851ea178df8f40888105c84ddbe5538532 /src/main/java/com/google/devtools/build/lib/rules/apple | |
parent | 542d4abce1673eadc76764f59d8bf0553c0dec38 (diff) |
Put the platform version from the options into the output directory name instead of the one computed based on xcode_config.
RELNOTES: None.
PiperOrigin-RevId: 172064337
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/apple')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java | 10 | ||||
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/apple/AppleConfiguration.java | 4 |
2 files changed, 7 insertions, 7 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java b/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java index c6ea84be26..1293c102c1 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java @@ -390,12 +390,12 @@ public class AppleCommandLineOptions extends FragmentOptions { /** * Returns whether the minimum OS version is explicitly set for the current platform. */ - public boolean isMinimumOsVersionExplicitlySet() { + public DottedVersion getMinimumOsVersion() { switch (applePlatformType) { - case IOS: return iosMinimumOs != null; - case MACOS: return macosMinimumOs != null; - case TVOS: return tvosMinimumOs != null; - case WATCHOS: return watchosMinimumOs != null; + case IOS: return iosMinimumOs; + case MACOS: return macosMinimumOs; + case TVOS: return tvosMinimumOs; + case WATCHOS: return watchosMinimumOs; default: throw new IllegalStateException(); } } diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/AppleConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/apple/AppleConfiguration.java index fd39b65fe5..752bf64e48 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/apple/AppleConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/apple/AppleConfiguration.java @@ -575,8 +575,8 @@ public class AppleConfiguration extends BuildConfiguration.Fragment { components.add(applePlatformType.toString().toLowerCase()); components.add(appleSplitCpu); - if (!isMandatoryMinimumVersion() || options.isMinimumOsVersionExplicitlySet()) { - components.add("min" + getMinimumOsForPlatformType(applePlatformType)); + if (options.getMinimumOsVersion() != null) { + components.add("min" + options.getMinimumOsVersion()); } } if (shouldDistinguishOutputDirectory()) { |