Refactor SkylarkInfo constructors

- Info now has one protected constructor. (Would've preferred the builder pattern, but inheritance makes it much more verbose.)
- Direct SkylarkInfo subclass access is replaced by factory methods and an isCompact() accessor.
- Added/simplified tests

RELNOTES: None
PiperOrigin-RevId: 181616757

1 files changed, 2 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java b/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java
index fa061530cf..0a446da63c 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java
@@ -234,7 +234,7 @@ public enum ApplePlatform implements SkylarkValue {
     for (ApplePlatform type : values()) {
       fields.put(type.skylarkKey, type);
     }
-    return SkylarkInfo.fromMap(constructor, fields, Location.BUILTIN);
+    return SkylarkInfo.createSchemaless(constructor, fields, Location.BUILTIN);
   }
 
   @Override
@@ -308,7 +308,7 @@ public enum ApplePlatform implements SkylarkValue {
       for (PlatformType type : values()) {
         fields.put(type.skylarkKey, type);
       }
-      return SkylarkInfo.fromMap(constructor, fields, Location.BUILTIN);
+      return SkylarkInfo.createSchemaless(constructor, fields, Location.BUILTIN);
     }
 
     @Override