aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
diff options
context:
space:
mode:
authorGravatar cparsons <cparsons@google.com>2017-08-31 17:55:26 +0200
committerGravatar Vladimir Moskva <vladmos@google.com>2017-08-31 18:28:42 +0200
commit82f71f56c221f81dcb08dadde831f98ad663b7d2 (patch)
treeb45bdaf10126806b9aaf8635e57a0b41a7d49ebe /src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
parentc480f4325b96db3e2b8dcdf4226812bc09c56de3 (diff)
Allow non-dottedversion aliases for --xcode_version
RELNOTES: None. PiperOrigin-RevId: 167143657
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java b/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
index b0b98c5380..dbe80f1568 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
@@ -97,6 +97,9 @@ public final class DottedVersion implements Comparable<DottedVersion>, SkylarkVa
* @throws IllegalArgumentException if the passed string is not a valid dotted version
*/
public static DottedVersion fromString(String version) {
+ if (Strings.isNullOrEmpty(version)) {
+ throw new IllegalArgumentException(String.format(ILLEGAL_VERSION, version));
+ }
ArrayList<Component> components = new ArrayList<>();
for (String component : DOT_SPLITTER.split(version)) {
components.add(toComponent(component, version));