aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
diff options
context:
space:
mode:
authorGravatar cparsons <cparsons@google.com>2018-05-23 15:24:42 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-05-23 15:26:28 -0700
commit0d31c7abc0b4f44e393aaf65b3397265229978ec (patch)
treebc854c25f587d5ab9e1192b6ee301554c3ddfb72 /src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
parent7c501fc5c28adee8e9735c7c12cad863fb497778 (diff)
Rename some instances of overloaded skylark-accessible methods
RELNOTES: None. PiperOrigin-RevId: 197799961
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java16
1 files changed, 10 insertions, 6 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java b/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
index 4082f1cf41..189462e947 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
@@ -160,12 +160,6 @@ public final class DottedVersion implements Comparable<DottedVersion>, SkylarkVa
}
@Override
- @SkylarkCallable(
- name = "compare_to",
- doc =
- "Compares based on most signifigant (first) not-matching version component. "
- + "So, for example, 1.2.3 < 1.2.4"
- )
public int compareTo(DottedVersion other) {
int maxComponents = Math.max(components.size(), other.components.size());
for (int componentIndex = 0; componentIndex < maxComponents; componentIndex++) {
@@ -179,6 +173,16 @@ public final class DottedVersion implements Comparable<DottedVersion>, SkylarkVa
return 0;
}
+ @SkylarkCallable(
+ name = "compare_to",
+ doc =
+ "Compares based on most significant (first) not-matching version component. "
+ + "So, for example, 1.2.3 < 1.2.4"
+ )
+ public int compareTo_skylark(DottedVersion other) {
+ return compareTo(other);
+ }
+
/**
* Returns the string representation of this dotted version, padded to a minimum number of
* components if the string representation does not already contain that many components.