diff options
author | 2018-06-04 21:35:55 -0700 | |
---|---|---|
committer | 2018-06-04 21:37:50 -0700 | |
commit | 699397a131e9853cb1221cbd16ad3ff7d814240a (patch) | |
tree | 39522842a5cf680dbe58c1de32335b79ddfb9eea /src/main/java/com/google/devtools/build/lib/rules/android | |
parent | 6f6a31b54303c605de705f0a05feb89ab809186a (diff) |
Remove the $(ANDROID_CPU) Make variable.
RELNOTES[INC]: The $(ANDROID_CPU) Make variable is not available anymore. Use $(TARGET_CPU) after an Android configuration transition instead.
PiperOrigin-RevId: 199241622
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/android')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java index dd00d3cd5a..e5f112064b 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java @@ -16,7 +16,6 @@ package com.google.devtools.build.lib.rules.android; import static com.google.devtools.build.lib.syntax.Type.STRING; import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import com.google.devtools.build.lib.analysis.RuleContext; import com.google.devtools.build.lib.analysis.config.BuildConfiguration; @@ -279,15 +278,6 @@ public class AndroidConfiguration extends BuildConfiguration.Fragment @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class Options extends FragmentOptions { @Option( - name = "experimental_enable_android_cpu_make_variable", - documentationCategory = OptionDocumentationCategory.UNDOCUMENTED, - effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS}, - metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE}, - defaultValue = "true", - help = "Flag to roll out the removal of the ANDROID_CPU Make variable.") - public boolean enableAndroidCpuMakeVariable; - - @Option( name = "Android configuration distinguisher", defaultValue = "MAIN", converter = ConfigurationDistinguisherConverter.class, @@ -898,7 +888,6 @@ public class AndroidConfiguration extends BuildConfiguration.Fragment } } - private final boolean enableAndroidCpuMakeVariable; private final Label sdk; private final String cpu; private final boolean useIncrementalNativeLibs; @@ -936,7 +925,6 @@ public class AndroidConfiguration extends BuildConfiguration.Fragment private final boolean oneVersionEnforcementUseTransitiveJarsForBinaryUnderTest; AndroidConfiguration(Options options) throws InvalidConfigurationException { - this.enableAndroidCpuMakeVariable = options.enableAndroidCpuMakeVariable; this.sdk = options.sdk; this.useIncrementalNativeLibs = options.incrementalNativeLibs; this.cpu = options.cpu; @@ -994,7 +982,6 @@ public class AndroidConfiguration extends BuildConfiguration.Fragment @AutoCodec.Instantiator AndroidConfiguration( - boolean enableAndroidCpuMakeVariable, Label sdk, String cpu, boolean useIncrementalNativeLibs, @@ -1030,7 +1017,6 @@ public class AndroidConfiguration extends BuildConfiguration.Fragment boolean decoupleDataProcessing, boolean checkForMigrationTag, boolean oneVersionEnforcementUseTransitiveJarsForBinaryUnderTest) { - this.enableAndroidCpuMakeVariable = enableAndroidCpuMakeVariable; this.sdk = sdk; this.cpu = cpu; this.useIncrementalNativeLibs = useIncrementalNativeLibs; @@ -1226,15 +1212,6 @@ public class AndroidConfiguration extends BuildConfiguration.Fragment } @Override - public void addGlobalMakeVariables(ImmutableMap.Builder<String, String> globalMakeEnvBuilder) { - if (!enableAndroidCpuMakeVariable) { - return; - } - - globalMakeEnvBuilder.put("ANDROID_CPU", cpu); - } - - @Override public String getOutputDirectoryName() { return configurationDistinguisher.suffix; } |