Add @CompileTimeConstant annotations to CustomCommandLine.

This enforces certain memory-efficient patterns. For deliberate use of dynamic strings, explicitly named overloads are introduced, with javadoc that guides the programmer into making the right choice.

This CL is a memory no-op on benchmarks, but it tries to prevent backslide by making sure programmers make conscious choices when they construct their command lines.

RELNOTES: None
PiperOrigin-RevId: 165185997

1 files changed, 1 insertions, 1 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/RobolectricResourceSymbolsActionBuilder.java b/src/main/java/com/google/devtools/build/lib/rules/android/RobolectricResourceSymbolsActionBuilder.java
index 17cd13bc9b..ce177f4830 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/android/RobolectricResourceSymbolsActionBuilder.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/android/RobolectricResourceSymbolsActionBuilder.java
@@ -89,7 +89,7 @@ public class RobolectricResourceSymbolsActionBuilder {
       builder.add(
           "--data",
           VectorArg.of(dependencies.getResources())
-              .joinWith(RESOURCE_CONTAINER_TO_ARG.listSeparator())
+              .joinWithDynamicString(RESOURCE_CONTAINER_TO_ARG.listSeparator())
               .mapEach(RESOURCE_CONTAINER_TO_ARG));
     }