aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2018-02-06 12:57:54 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-02-06 12:59:59 -0800
commitbeefb2c0a578f47f180bde1e42b1c12b61b8835d (patch)
tree2c564032abdd01b54b0c63099933354418fa97ef /src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
parentfe68c6b586e96aff48259f78f82568c59260a1ef (diff)
Don't generate the blaze generated extension registry for Android tests that define a binary_under_test.
They are filtered out for deployment anyways so it's unnecessary work and it confuses the one version detector. RELNOTES: n/a PiperOrigin-RevId: 184725205
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
index ad5def1d46..ab914bcea7 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
@@ -474,7 +474,8 @@ public class AndroidCommon {
boolean addCoverageSupport,
boolean collectJavaCompilationArgs,
boolean isBinary,
- NestedSet<Artifact> excludedRuntimeArtifacts)
+ NestedSet<Artifact> excludedRuntimeArtifacts,
+ boolean generateExtensionRegistry)
throws InterruptedException, RuleErrorException {
classJar = ruleContext.getImplicitOutputArtifact(AndroidRuleClasses.ANDROID_LIBRARY_CLASS_JAR);
@@ -554,7 +555,7 @@ public class AndroidCommon {
artifactsBuilder,
collectJavaCompilationArgs,
filesBuilder,
- isBinary);
+ generateExtensionRegistry);
if (ruleContext.hasErrors()) {
return null;
}
@@ -605,7 +606,7 @@ public class AndroidCommon {
JavaCompilationArtifacts.Builder javaArtifactsBuilder,
boolean collectJavaCompilationArgs,
NestedSetBuilder<Artifact> filesBuilder,
- boolean isBinary)
+ boolean generateExtensionRegistry)
throws InterruptedException {
JavaTargetAttributes attributes = helper.getAttributes();
if (ruleContext.hasErrors()) {
@@ -651,7 +652,7 @@ public class AndroidCommon {
javaArtifactsBuilder,
nativeHeaderOutput);
- if (isBinary) {
+ if (generateExtensionRegistry) {
generatedExtensionRegistryProvider =
javaSemantics.createGeneratedExtensionRegistry(
ruleContext,