diff options
| author |  Ulf Adams <ulfjack@google.com> | 2016-02-09 12:52:48 +0000 |
|---|---|---|
| committer |  Dmitry Lomov <dslomov@google.com> | 2016-02-10 10:22:19 +0000 |
| commit | 2a7c9b821e625ec0ea44120787ba38097d8dabec (patch) | |
| tree | 1f3a05a087260b037d4fa81c428774bd876b1d17 /src/main/java/com/google/devtools/build/lib/rules/SkylarkModules.java | |
| parent | 2b37dffcf30c985485ae323accc1c238ffc5ef5d (diff) | |
Remove the genfilesPath parameter from FdoSupport.prepareToBuild.
This makes the fdo support independent of the configuration, and therefore
safe to cache.
The genfilesPath was only used in AutoFDO builds, which now use the full
exec path to look up profiling data. The profile already refers to imported
files through their full exec paths, so this approach is more consistent.
Furthermore, if we ever have a source file with the same root-relative path as
a generated file, these would conflict in the FdoSupport map, potentially
leading to errors in the build. This may not be possible right now since such
files would conflict in the label namespace and such conflicts are always
resolved towards the generated file.
--
MOS_MIGRATED_REVID=114204994
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/SkylarkModules.java')
0 files changed, 0 insertions, 0 deletions