aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/remote
diff options
context:
space:
mode:
authorGravatar ulfjack <ulfjack@google.com>2017-07-24 12:18:42 +0200
committerGravatar Jakob Buchgraber <buchgr@google.com>2017-07-24 13:18:59 +0200
commit83c267f4867b6f0b629f59d3e823c06ac5339a40 (patch)
tree89a850aaa2b8a75ac20eb1ba68c4f52a708b9dd2 /src/main/java/com/google/devtools/build/lib/remote
parentbcc569efba8ac6c8a72ffe78b85bf9e786485afc (diff)
Simplify RemoteActionContextProvider
PiperOrigin-RevId: 162915070
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/remote')
-rw-r--r--src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java15
1 files changed, 3 insertions, 12 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java
index 368af4099f..79ad85b6cf 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java
@@ -17,8 +17,6 @@ import static com.google.common.base.Preconditions.checkNotNull;
import com.google.common.collect.ImmutableList;
import com.google.devtools.build.lib.actions.ActionContext;
-import com.google.devtools.build.lib.actions.ActionInputFileCache;
-import com.google.devtools.build.lib.actions.ActionInputPrefetcher;
import com.google.devtools.build.lib.actions.ResourceManager;
import com.google.devtools.build.lib.exec.ActionContextProvider;
import com.google.devtools.build.lib.exec.ExecutionOptions;
@@ -40,7 +38,6 @@ final class RemoteActionContextProvider extends ActionContextProvider {
private final GrpcRemoteExecutor executor;
private RemoteSpawnRunner spawnRunner;
- private RemoteSpawnStrategy spawnStrategy;
RemoteActionContextProvider(CommandEnvironment env, @Nullable RemoteActionCache cache,
@Nullable GrpcRemoteExecutor executor) {
@@ -50,8 +47,7 @@ final class RemoteActionContextProvider extends ActionContextProvider {
}
@Override
- public void init(
- ActionInputFileCache actionInputFileCache, ActionInputPrefetcher actionInputPrefetcher) {
+ public Iterable<? extends ActionContext> getActionContexts() {
ExecutionOptions executionOptions =
checkNotNull(env.getOptions().getOptions(ExecutionOptions.class));
RemoteOptions remoteOptions = checkNotNull(env.getOptions().getOptions(RemoteOptions.class));
@@ -62,10 +58,11 @@ final class RemoteActionContextProvider extends ActionContextProvider {
createFallbackRunner(env),
cache,
executor);
- spawnStrategy =
+ RemoteSpawnStrategy spawnStrategy =
new RemoteSpawnStrategy(
spawnRunner,
executionOptions.verboseFailures);
+ return ImmutableList.of(checkNotNull(spawnStrategy));
}
private static SpawnRunner createFallbackRunner(CommandEnvironment env) {
@@ -84,16 +81,10 @@ final class RemoteActionContextProvider extends ActionContextProvider {
}
@Override
- public Iterable<? extends ActionContext> getActionContexts() {
- return ImmutableList.of(checkNotNull(spawnStrategy));
- }
-
- @Override
public void executionPhaseEnding() {
if (spawnRunner != null) {
spawnRunner.close();
}
spawnRunner = null;
- spawnStrategy = null;
}
}