diff options
author | 2017-09-08 15:58:43 +0200 | |
---|---|---|
committer | 2017-09-11 13:06:58 +0200 | |
commit | 5c3467f2d251ae85889caca627794a8f9ff726b2 (patch) | |
tree | fb73e3d2f21637765430b06f0d8c1152cf8afd9b /src/main/java/com/google/devtools/build/lib/remote | |
parent | f322ba774727597b3238c33929c7ef2071f134b4 (diff) |
ActionInputFileCache: move getMetadata to a new super-interface
Update the callers that only need getMetadata to use the new interface.
PiperOrigin-RevId: 167992239
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/remote')
4 files changed, 10 insertions, 10 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/remote/Chunker.java b/src/main/java/com/google/devtools/build/lib/remote/Chunker.java index 8ffdb71e5d..1c7a66fda2 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/Chunker.java +++ b/src/main/java/com/google/devtools/build/lib/remote/Chunker.java @@ -21,7 +21,7 @@ import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Throwables; import com.google.common.io.ByteStreams; import com.google.devtools.build.lib.actions.ActionInput; -import com.google.devtools.build.lib.actions.ActionInputFileCache; +import com.google.devtools.build.lib.actions.MetadataProvider; import com.google.devtools.build.lib.vfs.Path; import com.google.devtools.remoteexecution.v1test.Digest; import com.google.protobuf.ByteString; @@ -137,12 +137,12 @@ public final class Chunker { }, Digests.computeDigest(file), chunkSize); } - public Chunker(ActionInput actionInput, ActionInputFileCache inputCache, Path execRoot) throws + public Chunker(ActionInput actionInput, MetadataProvider inputCache, Path execRoot) throws IOException{ this(actionInput, inputCache, execRoot, getDefaultChunkSize()); } - public Chunker(ActionInput actionInput, ActionInputFileCache inputCache, Path execRoot, + public Chunker(ActionInput actionInput, MetadataProvider inputCache, Path execRoot, int chunkSize) throws IOException { this(() -> { diff --git a/src/main/java/com/google/devtools/build/lib/remote/Digests.java b/src/main/java/com/google/devtools/build/lib/remote/Digests.java index ecb1626cdd..eadcb4c57e 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/Digests.java +++ b/src/main/java/com/google/devtools/build/lib/remote/Digests.java @@ -18,7 +18,7 @@ import static java.nio.charset.StandardCharsets.UTF_8; import com.google.common.hash.HashCode; import com.google.devtools.build.lib.actions.ActionInput; -import com.google.devtools.build.lib.actions.ActionInputFileCache; +import com.google.devtools.build.lib.actions.MetadataProvider; import com.google.devtools.build.lib.actions.cache.DigestUtils; import com.google.devtools.build.lib.actions.cache.Metadata; import com.google.devtools.build.lib.actions.cache.VirtualActionInput; @@ -102,7 +102,7 @@ public final class Digests { return Digest.newBuilder().setHash(hexHash).setSizeBytes(size).build(); } - public static Digest getDigestFromInputCache(ActionInput input, ActionInputFileCache cache) + public static Digest getDigestFromInputCache(ActionInput input, MetadataProvider cache) throws IOException { Metadata metadata = cache.getMetadata(input); return buildDigest(metadata.getDigest(), metadata.getSize()); diff --git a/src/main/java/com/google/devtools/build/lib/remote/GrpcRemoteCache.java b/src/main/java/com/google/devtools/build/lib/remote/GrpcRemoteCache.java index f9785a8909..ee7ef666e3 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/GrpcRemoteCache.java +++ b/src/main/java/com/google/devtools/build/lib/remote/GrpcRemoteCache.java @@ -24,9 +24,9 @@ import com.google.common.collect.ImmutableSet; import com.google.common.util.concurrent.ListeningScheduledExecutorService; import com.google.common.util.concurrent.MoreExecutors; import com.google.devtools.build.lib.actions.ActionInput; -import com.google.devtools.build.lib.actions.ActionInputFileCache; import com.google.devtools.build.lib.actions.EnvironmentalExecException; import com.google.devtools.build.lib.actions.ExecException; +import com.google.devtools.build.lib.actions.MetadataProvider; import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe; import com.google.devtools.build.lib.remote.Digests.ActionKey; import com.google.devtools.build.lib.remote.TreeNodeRepository.TreeNode; @@ -156,7 +156,7 @@ public class GrpcRemoteCache implements RemoteActionCache { uploadBlob(command.toByteArray()); if (!missingActionInputs.isEmpty()) { List<Chunker> inputsToUpload = new ArrayList<>(); - ActionInputFileCache inputFileCache = repository.getInputFileCache(); + MetadataProvider inputFileCache = repository.getInputFileCache(); for (ActionInput actionInput : missingActionInputs) { inputsToUpload.add(new Chunker(actionInput, inputFileCache, execRoot)); } @@ -374,7 +374,7 @@ public class GrpcRemoteCache implements RemoteActionCache { * * @return The key for fetching the file contents blob from cache. */ - Digest uploadFileContents(ActionInput input, Path execRoot, ActionInputFileCache inputCache) + Digest uploadFileContents(ActionInput input, Path execRoot, MetadataProvider inputCache) throws IOException, InterruptedException { Digest digest = Digests.getDigestFromInputCache(input, inputCache); ImmutableSet<Digest> missing = getMissingDigests(ImmutableList.of(digest)); diff --git a/src/main/java/com/google/devtools/build/lib/remote/SimpleBlobStoreActionCache.java b/src/main/java/com/google/devtools/build/lib/remote/SimpleBlobStoreActionCache.java index 641cf64f11..6fef48f178 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/SimpleBlobStoreActionCache.java +++ b/src/main/java/com/google/devtools/build/lib/remote/SimpleBlobStoreActionCache.java @@ -15,9 +15,9 @@ package com.google.devtools.build.lib.remote; import com.google.devtools.build.lib.actions.ActionInput; -import com.google.devtools.build.lib.actions.ActionInputFileCache; import com.google.devtools.build.lib.actions.EnvironmentalExecException; import com.google.devtools.build.lib.actions.ExecException; +import com.google.devtools.build.lib.actions.MetadataProvider; import com.google.devtools.build.lib.actions.cache.VirtualActionInput; import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe; import com.google.devtools.build.lib.remote.Digests.ActionKey; @@ -99,7 +99,7 @@ public final class SimpleBlobStoreActionCache implements RemoteActionCache { } private Digest uploadFileContents( - ActionInput input, Path execRoot, ActionInputFileCache inputCache) + ActionInput input, Path execRoot, MetadataProvider inputCache) throws IOException, InterruptedException { // This unconditionally reads the whole file into memory first! if (input instanceof VirtualActionInput) { |