aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java
diff options
context:
space:
mode:
authorGravatar Nathan Harmata <nharmata@google.com>2016-07-14 19:42:43 +0000
committerGravatar Dmitry Lomov <dslomov@google.com>2016-07-15 13:31:00 +0000
commit3aa7e131c27e8f344871b7e72fc1fec5c2ba77a9 (patch)
tree6eddd2a4688e237715f438fc45e73c1367516d50 /src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java
parent6c693a15a23b29e5d97fd0849b31367541e48bca (diff)
Fix embarassing typo in VariableContext#with.
Turns out that our existing test coverage was insufficient for catching this (I misread the tests during development of unknown commit and thus incorrectly thought we had test coverage for this). -- MOS_MIGRATED_REVID=127461716
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java b/src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java
index a75f890d1b..1c23334f45 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/engine/VariableContext.java
@@ -52,7 +52,7 @@ public class VariableContext<T> {
Set<T> value) {
ImmutableMap.Builder<String, Set<T>> newContextBuilder = ImmutableMap.builder();
for (Map.Entry<String, Set<T>> entry : variableContext.context.entrySet()) {
- if (entry.getKey().equals(name)) {
+ if (!entry.getKey().equals(name)) {
// The binding of 'name' to 'value' should override any existing binding of name in
// 'variableContext'. These are the semantics we want in order for nested let-expressions
// to have the semantics we want.