diff options
| author |  laurentlb <laurentlb@google.com> | 2018-05-22 09:43:18 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-05-22 09:45:30 -0700 |
| commit | 98ad85c78cdefd100f03946b6fb0d1109995a2c5 (patch) | |
| tree | 9a04255587421b819229effc0d4dc77a5273a8ba /src/main/java/com/google/devtools/build/lib/profiler | |
| parent | fd0aec8adae7785ca5aecd21886dacd5d9e5091e (diff) | |
Skylark: do not eagerly scan the whole file
With this change, the parser explicitly asks the lexer to give the next token.
To avoid changing the lexer too much, the tokenize() method populates a queue (it may add multiple tokens at the same time). While this reduces the peak memory usage, further work is needed to actually improve the performance.
RELNOTES: None.
PiperOrigin-RevId: 197576326
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/profiler')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/profiler/ProfilerTask.java | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/profiler/ProfilerTask.java b/src/main/java/com/google/devtools/build/lib/profiler/ProfilerTask.java index 9c17ef9173..8f7e3d1693 100644 --- a/src/main/java/com/google/devtools/build/lib/profiler/ProfilerTask.java +++ b/src/main/java/com/google/devtools/build/lib/profiler/ProfilerTask.java @@ -84,7 +84,6 @@ public enum ProfilerTask { CONSTRUCT_INCLUDE_PATHS("construct include paths"), PARSE_AND_HINTS_RESULTS("parse and hints results"), PROCESS_RESULTS_AND_ENQUEUE("process results and enqueue"), - SKYLARK_LEXER("Skylark Lexer"), SKYLARK_PARSER("Skylark Parser"), SKYLARK_USER_FN("Skylark user function call", -1, 0xCC0033, 0), SKYLARK_BUILTIN_FN("Skylark builtin function call", -1, 0x990033, 0), |