diff options
| author |  michajlo <michajlo@google.com> | 2018-04-24 17:02:51 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-04-24 17:04:05 -0700 |
| commit | 8a1b4ab0aaa4b1accb5defaee15a33db9b4cd95b (patch) | |
| tree | bc98f67af4aa89934f63f9c4f8dc2b4f78a04674 /src/main/java/com/google/devtools/build/lib/profiler/Profiler.java | |
| parent | 7b0d676d5f91bbc6778e99902b7667a395303b86 (diff) | |
Fix profiler slow task limiting
Looks like a typo resulted in getSlowestTasks accumulating way more than it
should have and we were missing the test coverage to catch it.
RELNOTES: None
PiperOrigin-RevId: 194169355
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/profiler/Profiler.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/profiler/Profiler.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java b/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java index e9113ce823..233f374c44 100644 --- a/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java +++ b/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java @@ -369,7 +369,7 @@ public final class Profiler { // @ThreadSafe Iterable<SlowTask> getSlowestTasks() { // This is slow, but since it only happens during the end of the invocation, it's OK - Extrema mergedExtrema = Extrema.max(size * SHARDS); + Extrema<SlowTask> mergedExtrema = Extrema.max(size); for (int i = 0; i < SHARDS; i++) { Extrema<SlowTask> extrema = extremaAggregators[i]; synchronized (extrema) { |