aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java
diff options
context:
space:
mode:
authorGravatar Ulf Adams <ulfjack@google.com>2017-02-07 16:06:39 +0000
committerGravatar Kristina Chodorow <kchodorow@google.com>2017-02-07 18:27:15 +0000
commit43765af888e5b3334e915b696205b835f56ae0ee (patch)
treef7d08fdce0c20119f77270956c8368a4eed1bbcf /src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java
parenta8bc05788acf224c1c91aa614a2ca7d4527d62f5 (diff)
Remove dead code in SkyframeLabelVisitor
Two of the functions are never used, several of the parameter are not used or can be simplified (require callers to convert from Target -> Label). -- PiperOrigin-RevId: 146787380 MOS_MIGRATED_REVID=146787380
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java34
1 files changed, 3 insertions, 31 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java b/src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java
index 45c7c931b1..0b40bda893 100644
--- a/src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java
+++ b/src/main/java/com/google/devtools/build/lib/pkgcache/TransitivePackageLoader.java
@@ -13,12 +13,8 @@
// limitations under the License.
package com.google.devtools.build.lib.pkgcache;
-import com.google.common.collect.Multimap;
import com.google.devtools.build.lib.cmdline.Label;
-import com.google.devtools.build.lib.cmdline.PackageIdentifier;
import com.google.devtools.build.lib.events.EventHandler;
-import com.google.devtools.build.lib.packages.Target;
-
import java.util.Set;
/**
@@ -32,36 +28,12 @@ public interface TransitivePackageLoader {
* may do an up-to-date check which will not trigger any of the observers.
*
* @param eventHandler the error and warnings eventHandler; must be thread-safe
- * @param targetsToVisit the targets to visit
* @param labelsToVisit the labels to visit in addition to the targets
- * @param keepGoing if false, stop visitation upon first error.
- * @param parallelThreads number of threads to use in the visitation.
- * @param maxDepth the maximum depth to traverse to.
+ * @param keepGoing if false, stop visitation upon first error
+ * @param parallelThreads number of threads to use in the visitation
*/
boolean sync(EventHandler eventHandler,
- Set<Target> targetsToVisit,
Set<Label> labelsToVisit,
boolean keepGoing,
- int parallelThreads,
- int maxDepth) throws InterruptedException;
-
- /**
- * Returns a read-only view of the set of packages visited since this visitor
- * was constructed.
- *
- * <p>Not thread-safe; do not call during visitation.
- */
- Set<PackageIdentifier> getVisitedPackageNames();
-
- /**
- * Return a mapping between the specified top-level targets and root causes. Note that targets in
- * the input that are transitively error free will not be in the output map. "Top-level" targets
- * are the targetsToVisit and labelsToVisit specified in the last sync.
- *
- * <p>May only be called once a keep_going visitation is complete, and prior to
- * trimErrorTracking().
- *
- * @return a mapping of targets to root causes
- */
- Multimap<Label, Label> getRootCauses();
+ int parallelThreads) throws InterruptedException;
}