diff options
author | 2018-02-20 09:11:01 -0800 | |
---|---|---|
committer | 2018-02-20 09:13:46 -0800 | |
commit | 1001141f0674ff4b611814edcb00a5183680ef4a (patch) | |
tree | 4fd6392052b2a61377eb2502533e51b2dd1fd04d /src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java | |
parent | fb915e8b7bd139e9c07e9354c43ab549e94cbc7a (diff) |
Roll forward of https://github.com/bazelbuild/bazel/commit/3904ac33a983fd8faebba1b52bcac5a3ff942029 (https://github.com/bazelbuild/bazel/commit/3904ac33a983fd8faebba1b52bcac5a3ff942029). Fix #4625 by running the test process in a sub-shell.
Apparently, nested background processes interfere with SIGINT handling in bash. I don't 100% understand why and how, but I do have a small bash script that demonstrates the problem: script A that spawns a background process, sends it a SIGINT, and verifies it was received. The script works, *unless* run in the background by a process B; this extra layer of backgrounding cause process A's logic to stop working. See experimental/users/olaola/shell/ for examples. See also https://stackoverflow.com/questions/48847722/nested-background-processes-and-sigint-handling
*** Original change description ***
Fixing test-setup.sh occasionally missing stdout/stderr, on systems where "tail --pid" is supported.
The solutions aren't mine, the new test was taken from Ola's unknown commit and the way to avoid race condition courtesy of sethkoehler@
Mitigates #4608 for compatible Linux systems.
TESTED=presubmits, manual shell tests on new bazel
RELNOTES: None
PiperOrigin-RevId: 186312008
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java')
0 files changed, 0 insertions, 0 deletions