diff options
author | Lukacs Berki <lberki@google.com> | 2015-09-18 11:40:12 +0000 |
---|---|---|
committer | Damien Martin-Guillerez <dmarting@google.com> | 2015-09-21 08:56:51 +0000 |
commit | ffa73addaf80ab7a9cf9f98e5d4414b152ae6cb6 (patch) | |
tree | f498621bb8634d934815dbaddf90400eda0ce28d /src/main/java/com/google/devtools/build/lib/packages/RuleClass.java | |
parent | 29ad862a5bd45d2fdbb921f36bbb95816cf47acc (diff) |
Separate build-specific types and types inherent to Skylark.
--
MOS_MIGRATED_REVID=103374106
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/packages/RuleClass.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/packages/RuleClass.java | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java index 34ff1aff55..2f442100ff 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java +++ b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java @@ -16,8 +16,8 @@ package com.google.devtools.build.lib.packages; import static com.google.devtools.build.lib.packages.Attribute.ConfigurationTransition.HOST; import static com.google.devtools.build.lib.packages.Attribute.attr; -import static com.google.devtools.build.lib.packages.Type.BOOLEAN; -import static com.google.devtools.build.lib.packages.Type.LABEL_LIST; +import static com.google.devtools.build.lib.packages.BuildType.LABEL_LIST; +import static com.google.devtools.build.lib.syntax.Type.BOOLEAN; import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Function; @@ -33,6 +33,7 @@ import com.google.devtools.build.lib.cmdline.LabelSyntaxException; import com.google.devtools.build.lib.events.EventHandler; import com.google.devtools.build.lib.events.Location; import com.google.devtools.build.lib.packages.Attribute.ConfigurationTransition; +import com.google.devtools.build.lib.packages.BuildType.SelectorList; import com.google.devtools.build.lib.packages.RuleClass.Builder.RuleClassType; import com.google.devtools.build.lib.syntax.Argument; import com.google.devtools.build.lib.syntax.BaseFunction; @@ -42,6 +43,7 @@ import com.google.devtools.build.lib.syntax.FuncallExpression; import com.google.devtools.build.lib.syntax.GlobList; import com.google.devtools.build.lib.syntax.Label; import com.google.devtools.build.lib.syntax.Runtime; +import com.google.devtools.build.lib.syntax.Type; import com.google.devtools.build.lib.util.StringUtil; import com.google.devtools.build.lib.vfs.PathFragment; @@ -1488,7 +1490,7 @@ public final class RuleClass { Set<Label> configLabels = new LinkedHashSet<>(); for (Attribute attr : rule.getAttributes()) { - Type.SelectorList<?> selectors = attributes.getSelectorList(attr.getName(), attr.getType()); + SelectorList<?> selectors = attributes.getSelectorList(attr.getName(), attr.getType()); if (selectors != null) { configLabels.addAll(selectors.getKeyLabels()); } @@ -1519,7 +1521,7 @@ public final class RuleClass { */ private static void checkForDuplicateLabels(Rule rule, EventHandler eventHandler) { for (Attribute attribute : rule.getAttributes()) { - if (attribute.getType() == Type.LABEL_LIST) { + if (attribute.getType() == BuildType.LABEL_LIST) { checkForDuplicateLabels(rule, attribute, eventHandler); } } @@ -1640,9 +1642,9 @@ public final class RuleClass { Object converted; try { String what = "attribute '" + attrName + "' in '" + name + "' rule"; - converted = attr.getType().selectableConvert(attrVal, what, rule.getLabel()); + converted = BuildType.selectableConvert(attr.getType(), attrVal, what, rule.getLabel()); - if ((converted instanceof Type.SelectorList<?>) && !attr.isConfigurable()) { + if ((converted instanceof SelectorList<?>) && !attr.isConfigurable()) { rule.reportError(rule.getLabel() + ": attribute \"" + attr.getName() + "\" is not configurable", eventHandler); return null; |