diff options
| author |  Ulf Adams <ulfjack@google.com> | 2015-03-05 14:47:37 +0000 |
|---|---|---|
| committer |  Han-Wen Nienhuys <hanwen@google.com> | 2015-03-05 18:31:47 +0000 |
| commit | 07dba941e21619830adcbcae10c5942cf3343f26 (patch) | |
| tree | c0e7b1250bf547b20398a0c3a437864b7b915383 /src/main/java/com/google/devtools/build/lib/packages/RuleClass.java | |
| parent | a34d5071784ff51f68714b61f4100c35f1e4db3a (diff) | |
Some cleanup changes.
--
MOS_MIGRATED_REVID=87821306
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/packages/RuleClass.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/packages/RuleClass.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java index b7da520982..23f1c97f59 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java +++ b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java @@ -240,7 +240,7 @@ public final class RuleClass { @Override public void checkName(String name) { Preconditions.checkArgument( - (name.contains("$") && !TargetUtils.isTestRuleName(name)) || name.equals("")); + (name.contains("$") && !TargetUtils.isTestRuleName(name)) || name.isEmpty()); } @Override @@ -274,8 +274,9 @@ public final class RuleClass { NORMAL { @Override public void checkName(String name) { - Preconditions.checkArgument(!TargetUtils.isTestRuleName(name) - && RULE_NAME_PATTERN.matcher(name).matches(), "Invalid rule name: " + name); + Preconditions.checkArgument( + !TargetUtils.isTestRuleName(name) && RULE_NAME_PATTERN.matcher(name).matches(), + "Invalid rule name: %s", name); } @Override |