diff options
| author |  Googler <noreply@google.com> | 2015-03-12 10:28:48 +0000 |
|---|---|---|
| committer |  Han-Wen Nienhuys <hanwen@google.com> | 2015-03-13 14:16:32 +0000 |
| commit | da64974207fe3859468d23dc5b48af546710387b (patch) | |
| tree | 42604cda3b507254876dc6fe3e8e6ab991efcee4 /src/main/java/com/google/devtools/build/lib/packages/Package.java | |
| parent | 12589f418383187269507a89c44beab4312dfa69 (diff) | |
BazelTestSuiteRule is documented. The "suites" attribute is removed from BazelTestSuiteRule.
- "suites" is deprecated
- it has the exact same functionality as "tests"
--
MOS_MIGRATED_REVID=88426066
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/packages/Package.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/packages/Package.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/Package.java b/src/main/java/com/google/devtools/build/lib/packages/Package.java index 186b9d949f..b65e35858f 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/Package.java +++ b/src/main/java/com/google/devtools/build/lib/packages/Package.java @@ -1348,7 +1348,8 @@ public class Package implements Serializable { AttributeMap attributes = NonconfigurableAttributeMapper.of(rule); if (rule.getRuleClass().equals("test_suite") && attributes.get("tests", Type.LABEL_LIST).isEmpty() - && attributes.get("suites", Type.LABEL_LIST).isEmpty()) { + && (!rule.getRuleClassObject().hasAttr("suites", Type.LABEL_LIST) + || attributes.get("suites", Type.LABEL_LIST).isEmpty())) { rule.setAttributeValueByName("$implicit_tests", allTests); } } |