aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
diff options
context:
space:
mode:
authorGravatar Lukacs Berki <lberki@google.com>2015-06-10 08:24:43 +0000
committerGravatar Philipp Wollermann <philwo@google.com>2015-06-10 16:03:01 +0000
commitbcb81ab35c02124e72acd03fcf0638144a9eb242 (patch)
treeefcff2eec8a31a1a482090d587ed9284eb67da1c /src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
parentde7cd0b3663a62da20607369a3cfad82cc7c627f (diff)
Description redacted.
-- MOS_MIGRATED_REVID=95615442
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java b/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
index 0c2368b6ea..10ba3ffbff 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
@@ -109,11 +109,11 @@ public final class AspectDefinition {
*/
public static ImmutableMultimap<Attribute, Label> visitAspectsIfRequired(
Target from, Attribute attribute, Target to) {
- ImmutableMultimap.Builder<Attribute, Label> labelBuilder = ImmutableMultimap.builder();
// Aspect can be declared only for Rules.
if (!(from instanceof Rule) || !(to instanceof Rule)) {
- return labelBuilder.build();
+ return ImmutableMultimap.of();
}
+ LinkedHashMultimap<Attribute, Label> result = LinkedHashMultimap.create();
RuleClass ruleClass = ((Rule) to).getRuleClassObject();
for (Class<? extends AspectFactory<?, ?, ?>> candidateClass : attribute.getAspects()) {
AspectFactory<?, ?, ?> candidate = AspectFactory.Util.create(candidateClass);
@@ -123,16 +123,16 @@ public final class AspectDefinition {
candidate.getDefinition().getRequiredProviders())) {
continue;
}
- addAllAttributesOfAspect((Rule) from, labelBuilder, candidate.getDefinition(), Rule.ALL_DEPS);
+ addAllAttributesOfAspect((Rule) from, result, candidate.getDefinition(), Rule.ALL_DEPS);
}
- return labelBuilder.build();
+ return ImmutableMultimap.copyOf(result);
}
/**
* Collects all attribute labels from the specified aspectDefinition.
*/
public static void addAllAttributesOfAspect(Rule from,
- ImmutableMultimap.Builder<Attribute, Label> labelBuilder, AspectDefinition aspectDefinition,
+ Multimap<Attribute, Label> labelBuilder, AspectDefinition aspectDefinition,
BinaryPredicate<Rule, Attribute> predicate) {
ImmutableMap<String, Attribute> attributes = aspectDefinition.getAttributes();
for (Attribute aspectAttribute : attributes.values()) {