aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/ideinfo
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2016-07-06 19:35:00 +0000
committerGravatar Klaus Aehlig <aehlig@google.com>2016-07-07 08:40:56 +0000
commita48e8e3db5a149777c2887fc7fc572837dd0ac1e (patch)
treecd526650bb3b717828b21db884a1083b2d2db36e /src/main/java/com/google/devtools/build/lib/ideinfo
parenteef3b2f7210a135a77e2e0e0809df7207e60fe78 (diff)
Add cc transitive headers to ide-resolve output group
Both source and generated hdrs are included in the output group. Might be cleaner to only include generated headers -- perhaps by adding a new field to CppCompilationContext. This solution seems lighter-weight, however. -- MOS_MIGRATED_REVID=126725901
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/ideinfo')
-rw-r--r--src/main/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspect.java8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspect.java b/src/main/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspect.java
index feddc68261..a7161f811a 100644
--- a/src/main/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspect.java
+++ b/src/main/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspect.java
@@ -341,7 +341,7 @@ public class AndroidStudioInfoAspect extends NativeAspectClass implements Config
ruleContext.registerAction(
makePackageManifestAction(ruleContext,
packageManifest,
- getJavaSourcefForPackageManifest(ruleContext)));
+ getJavaSourceForPackageManifest(ruleContext)));
}
JavaRuleIdeInfo javaRuleIdeInfo = makeJavaRuleIdeInfo(
@@ -432,7 +432,7 @@ public class AndroidStudioInfoAspect extends NativeAspectClass implements Config
@Nullable private static Artifact createPackageManifest(ConfiguredTarget base,
RuleContext ruleContext) {
- Collection<Artifact> sourceFiles = getJavaSourcefForPackageManifest(ruleContext);
+ Collection<Artifact> sourceFiles = getJavaSourceForPackageManifest(ruleContext);
if (sourceFiles.isEmpty()) {
return null;
}
@@ -646,6 +646,8 @@ public class AndroidStudioInfoAspect extends NativeAspectClass implements Config
builder.addSource(makeArtifactLocation(sourceFile));
}
+ ideResolveArtifacts.addTransitive(cppCompilationContext.getDeclaredIncludeSrcs());
+
builder.addAllRuleInclude(getIncludes(ruleContext));
builder.addAllRuleDefine(getDefines(ruleContext));
builder.addAllRuleCopt(getCopts(ruleContext));
@@ -768,7 +770,7 @@ public class AndroidStudioInfoAspect extends NativeAspectClass implements Config
}
}
- private static Collection<Artifact> getJavaSourcefForPackageManifest(RuleContext ruleContext) {
+ private static Collection<Artifact> getJavaSourceForPackageManifest(RuleContext ruleContext) {
Collection<Artifact> srcs = getSources(ruleContext);
List<Artifact> javaSrcs = Lists.newArrayList();
for (Artifact src : srcs) {