aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/exec
diff options
context:
space:
mode:
authorGravatar Janak Ramakrishnan <janakr@google.com>2015-03-19 15:32:22 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-03-20 14:34:46 +0000
commit6f49384fb69744b0d7a3542b0534dfb85d17de23 (patch)
tree582f760f04b8da0e5c69511d8ad64c01007c4688 /src/main/java/com/google/devtools/build/lib/exec
parent1a03eccae276227853d693c208ff623b9cf3d902 (diff)
Rolling back change because of subtle race condition when multiple actions insert ActionInputs into SingleBuildFileCache.
-- MOS_MIGRATED_REVID=89032980
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/exec')
-rw-r--r--src/main/java/com/google/devtools/build/lib/exec/SingleBuildFileCache.java14
1 files changed, 3 insertions, 11 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/exec/SingleBuildFileCache.java b/src/main/java/com/google/devtools/build/lib/exec/SingleBuildFileCache.java
index ddbe12a14a..8ec1e51583 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/SingleBuildFileCache.java
+++ b/src/main/java/com/google/devtools/build/lib/exec/SingleBuildFileCache.java
@@ -23,7 +23,6 @@ import com.google.common.collect.Maps;
import com.google.common.io.BaseEncoding;
import com.google.devtools.build.lib.actions.ActionInput;
import com.google.devtools.build.lib.actions.ActionInputFileCache;
-import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.DigestOfDirectoryException;
import com.google.devtools.build.lib.util.Pair;
import com.google.devtools.build.lib.vfs.FileSystem;
@@ -100,16 +99,9 @@ public class SingleBuildFileCache implements ActionInputFileCache {
@Nullable
@Override
- public ActionInput getInputFromDigest(ByteString digest) {
- return digestToPath.get(digest);
- }
-
- @Override
- public Path getInputPath(ActionInput input) {
- if (input instanceof Artifact) {
- return ((Artifact) input).getPath();
- }
- return fs.getPath(fullPath(input));
+ public File getFileFromDigest(ByteString digest) {
+ ActionInput relPath = digestToPath.get(digest);
+ return relPath == null ? null : new File(fullPath(relPath));
}
@Override