Improve overhead/safety of RecorderStream

Bypass converting bytes to string - RecordOutputStream is typically used to
wrap stdout/err, which we write bytes to, the string step is waste.

Make defensive copies of byte[]s passed to Event since Event doesn't.

--
MOS_MIGRATED_REVID=137949714

1 files changed, 3 insertions, 5 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/events/ReporterStream.java b/src/main/java/com/google/devtools/build/lib/events/ReporterStream.java
index e72f4a96b9..1669fa7b62 100644
--- a/src/main/java/com/google/devtools/build/lib/events/ReporterStream.java
+++ b/src/main/java/com/google/devtools/build/lib/events/ReporterStream.java
@@ -14,11 +14,9 @@
 
 package com.google.devtools.build.lib.events;
 
-import static java.nio.charset.StandardCharsets.ISO_8859_1;
-
 import com.google.devtools.build.lib.util.Preconditions;
-
 import java.io.OutputStream;
+import java.util.Arrays;
 
 /**
  * An OutputStream that delegates all writes to a Reporter.
@@ -49,11 +47,11 @@ public final class ReporterStream extends OutputStream {
 
   @Override
   public void write(byte[] bytes) {
-    reporter.handle(Event.of(eventKind, null, bytes));
+    write(bytes, 0, bytes.length);
   }
 
   @Override
   public void write(byte[] bytes, int offset, int len) {
-    reporter.handle(Event.of(eventKind, null, new String(bytes, offset, len, ISO_8859_1)));
+    reporter.handle(Event.of(eventKind, null, Arrays.copyOfRange(bytes, offset, offset + len)));
   }
 }