diff options
author | janakr <janakr@google.com> | 2018-08-13 16:13:42 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-08-13 16:15:46 -0700 |
commit | 6ae05b419922193c4c253e51c9a5e483e4f947fa (patch) | |
tree | e06491f807689124cad73a2011af2db821e390e1 /src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java | |
parent | ce170540ba5401e926a5433e6e35b1d22426e525 (diff) |
Order Skyframe evaluations in a priority queue, with all children of a given node having the same priority, later enqueueings having higher priority, re-enqueued nodes having highest priority, and new root nodes having lowest priority. Experimentally, this can save significant RAM (1.4G in some builds!) while not affecting speed.
Also do a semi-drive-by deleting ExecutorFactory parameter to AbstractQueueVisitor, since it was always AbstractQueueVisitor.EXECUTOR_FACTORY.
PiperOrigin-RevId: 208560889
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java b/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java index 005d4f1ac9..89a7454f0f 100644 --- a/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java +++ b/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java @@ -92,7 +92,7 @@ public class ForkJoinQuiescingExecutor extends AbstractQueueVisitor { } @Override - protected void executeRunnable(Runnable runnable) { + protected void executeRunnable(WrappedRunnable runnable) { if (ForkJoinTask.inForkJoinPool()) { @SuppressWarnings("unused") Future<?> possiblyIgnoredError = ForkJoinTask.adapt(runnable).fork(); |