diff options
| author |  janakr <janakr@google.com> | 2017-05-08 14:49:00 -0400 |
|---|---|---|
| committer |  Kristina Chodorow <kchodorow@google.com> | 2017-05-09 10:52:36 -0400 |
| commit | 1f75476f7a2f1abb449d538ef865f51ac138d013 (patch) | |
| tree | 7335b500ba5bb34b5f97fb4cd30917376a38810e /src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java | |
| parent | cc0f6a62d5262760d34937547470a213f6bd5b72 (diff) | |
Clean up AbstractQueueVisitor's constructors.
The "concurrent" bit was supposedly around for testing purposes, but who knows if it even works anymore. Making other callsites explicitly state their ErrorClassifier gets us down to two constructors, one of which can delegate to the other.
I think having both these constructors is useful because there's a linkage between creating a new executor service and specifying that the AQV should shut down the service at the end of the visitation. And using a static create() method doesn't work because of AQV's inheritance model.
PiperOrigin-RevId: 155406771
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java b/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java index ca2b38da44..295e758628 100644 --- a/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java +++ b/src/main/java/com/google/devtools/build/lib/concurrent/ForkJoinQuiescingExecutor.java @@ -28,7 +28,6 @@ public class ForkJoinQuiescingExecutor extends AbstractQueueVisitor { private ForkJoinQuiescingExecutor( ForkJoinPool forkJoinPool, ErrorClassifier errorClassifier, boolean shutdownOnCompletion) { super( - /*concurrent=*/ true, forkJoinPool, shutdownOnCompletion, /*failFastOnException=*/ true, |