diff options
| author |  janakr <janakr@google.com> | 2018-07-17 16:40:58 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-07-17 16:42:50 -0700 |
| commit | f309ad3be36363070e87eef0ee04b12f4956d601 (patch) | |
| tree | db154ca3e5b54bb4470ea9b5d071dd17f33c927c /src/main/java/com/google/devtools/build/lib/collect | |
| parent | ceafeaef5977d0671c44c86864b9a4b2b0e5ee04 (diff) | |
Automated rollback of commit d491bf10f42e213292382c98a1dc439537f00f43.
*** Reason for rollback ***
Still bugs lurking. See linked bug.
*** Original change description ***
Automated rollback of commit eb587075b0d6ffab1cf9e69ede1b7e547905e547.
*** Reason for rollback ***
Depot has been fixed.
RELNOTES[INC]: If the same artifact is generated by two distinct but identical actions, and a downstream action has both those actions' outputs in its inputs, the artifact will now appear twice in the downstream action's inputs. If this causes problems in Skylark actions, you can use the uniquify=True argument in Args.add_args.
PiperOrigin-RevId: 204997569
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/collect')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetCodecWithStore.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetCodecWithStore.java b/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetCodecWithStore.java index 1496bc288e..fa835618ec 100644 --- a/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetCodecWithStore.java +++ b/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSetCodecWithStore.java @@ -126,7 +126,8 @@ public class NestedSetCodecWithStore implements ObjectCodec<NestedSet<?>> { * NestedSet#getChildren()}. When that field is an Object[], this is just identity hash code and * reference equality, but when it is something else (like an Artifact), we will do an actual * equality comparison. This may make some singleton NestedSets reference-equal where they were - * not before. This should be ok as long as the contained object properly implements equality. + * not before. This should be ok, but isn't because Artifact does not properly implement equality + * (it ignores the ArtifactOwner). */ @SuppressWarnings("unchecked") private NestedSet<?> intern(Order order, Object contents) { |