diff options
| author |  janakr <janakr@google.com> | 2018-04-03 15:25:16 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-04-03 15:27:03 -0700 |
| commit | 7e8110b8dedfef1562e7337ad67b63525c9ae8b1 (patch) | |
| tree | bf0b2b07837c69045b05ac3b95e20ec42fa95c54 /src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD | |
| parent | e3824d43223e63c147c39416b011bc84ed6bbdee (diff) | |
Disable nested set sharing across multiple nested set deserialization sessions. This is incorrect in the presence of memoization: a single element may be serialized as just a pair of integers (type + memoization index). Lots of different nested sets may contain elements that are serialized this way, so they will have the same digests. We could consider doing a parallel hash computation, but for now just disable.
This is not a full rollback of https://github.com/bazelbuild/bazel/commit/39cef6d6a4a9e3ae80b11a9ccc0f35325852777c since there was a refactoring in it that it doesn't seem worth it to roll back.
PiperOrigin-RevId: 191509089
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD b/src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD index 09be2fbb75..dbf0d0684a 100644 --- a/src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD +++ b/src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD @@ -19,9 +19,7 @@ java_library( ], deps = [ "//src/main/java/com/google/devtools/build/lib/collect/compacthashset", - "//src/main/java/com/google/devtools/build/lib/concurrent", "//src/main/java/com/google/devtools/build/lib/skyframe/serialization", - "//src/main/java/com/google/devtools/build/lib/skyframe/serialization:constants", "//third_party:guava", "//third_party:jsr305", "//third_party/protobuf:protobuf_java", |