diff options
| author |  ulfjack <ulfjack@google.com> | 2018-06-07 07:05:37 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-07 07:07:11 -0700 |
| commit | aa2ff99ac6fbdbd2efaa6af75de0a285dd1120ca (patch) | |
| tree | f50782b4f1fb51e8711e8e7d480e2d85a331534c /src/main/java/com/google/devtools/build/lib/cmdline | |
| parent | 59fb8fabbc668107abbb039115e9d01fad100832 (diff) | |
Fix bug in skyframe-based test-suite expansion
It was tracking filtered tests and then applying the filter at the next higher
level.
I also added a bunch of comments - we actually have four implementations of
test suite expansion, and they are not consistent. Sorry about that.
PiperOrigin-RevId: 199629485
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/cmdline')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/cmdline/ResolvedTargets.java | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/cmdline/ResolvedTargets.java b/src/main/java/com/google/devtools/build/lib/cmdline/ResolvedTargets.java index e06f9d7aea..5f4c818682 100644 --- a/src/main/java/com/google/devtools/build/lib/cmdline/ResolvedTargets.java +++ b/src/main/java/com/google/devtools/build/lib/cmdline/ResolvedTargets.java @@ -16,10 +16,9 @@ package com.google.devtools.build.lib.cmdline; import com.google.common.base.Predicate; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Sets; - import java.util.Collection; +import java.util.LinkedHashSet; import java.util.Set; - import javax.annotation.concurrent.Immutable; /** @@ -102,7 +101,7 @@ public final class ResolvedTargets<T> { private volatile boolean hasError = false; private Builder() { - this(Sets.<T>newLinkedHashSet(), Sets.<T>newLinkedHashSet()); + this(new LinkedHashSet<>(), new LinkedHashSet<>()); } private Builder(Set<T> targets, Set<T> filteredTargets) { |