aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/cmdline
diff options
context:
space:
mode:
authorGravatar tomlu <tomlu@google.com>2018-02-12 10:11:09 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-02-12 10:13:08 -0800
commit17ec4c9554f763683621a4fcbab54ed12431ed47 (patch)
tree1a912b6906e59b9822ef603fe8ea1102ba06de58 /src/main/java/com/google/devtools/build/lib/cmdline
parent2950f318733ff886591434126036d796c24f99e1 (diff)
Remove label name interning.
We already intern the labels themselves. Benchmarks do not show any further gain by interning the label names. RELNOTES: None PiperOrigin-RevId: 185394812
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/cmdline')
-rw-r--r--src/main/java/com/google/devtools/build/lib/cmdline/Label.java3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/cmdline/Label.java b/src/main/java/com/google/devtools/build/lib/cmdline/Label.java
index 054648dd18..b067bc2fc9 100644
--- a/src/main/java/com/google/devtools/build/lib/cmdline/Label.java
+++ b/src/main/java/com/google/devtools/build/lib/cmdline/Label.java
@@ -28,7 +28,6 @@ import com.google.devtools.build.lib.skylarkinterface.SkylarkModule;
import com.google.devtools.build.lib.skylarkinterface.SkylarkModuleCategory;
import com.google.devtools.build.lib.skylarkinterface.SkylarkPrinter;
import com.google.devtools.build.lib.skylarkinterface.SkylarkValue;
-import com.google.devtools.build.lib.util.StringCanonicalizer;
import com.google.devtools.build.lib.util.StringUtilities;
import com.google.devtools.build.lib.vfs.PathFragment;
import com.google.devtools.build.skyframe.SkyFunctionName;
@@ -189,7 +188,7 @@ public final class Label
* arbitrary {@code targetName} inputs
*/
public static Label createUnvalidated(PackageIdentifier packageId, String targetName) {
- return LABEL_INTERNER.intern(new Label(packageId, StringCanonicalizer.intern(targetName)));
+ return LABEL_INTERNER.intern(new Label(packageId, targetName));
}
/**