diff options
author | 2016-10-13 19:18:13 +0000 | |
---|---|---|
committer | 2016-10-14 09:32:58 +0000 | |
commit | 2c91836c8d4232f26a5b764ea91b7cdb47240b7e (patch) | |
tree | 0b1d6be682f727627d1b3cd305d351eed4b854a0 /src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java | |
parent | 0c7a42a09d85ddffd9b860bcb31e4c43a00632c1 (diff) |
Rollback of commit 2891ec527eed27d0c6460d66f51cb66a43373b6a.
*** Reason for rollback ***
Causes our integration tests on Darwin to time out
*** Original change description ***
Make --watchfs a common command option.
Adding an options parameter to DiffAwareness#getCurrentView seems like the
simplest way to achieve that.
Alternatives considered:
1. Making the diff awareness modules stateful. However, I did not want to do so
as I've also been working on improving the module API to reduce state, or at
least to have a proper lifecycle management for any necessary state.
2. Making the watchFs flag a constructor parameter. However, that would also
invalidate any implement...
***
--
MOS_MIGRATED_REVID=136070807
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java b/src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java index 9857283f62..e0f9682061 100644 --- a/src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java +++ b/src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java @@ -134,7 +134,8 @@ public final class BuildTool { validateOptions(request); BuildOptions buildOptions = runtime.createBuildOptions(request); // Sync the package manager before sending the BuildStartingEvent in runLoadingPhase() - env.setupPackageCache(request, DefaultsPackage.getDefaultsPackageContent(buildOptions)); + env.setupPackageCache(request.getPackageCacheOptions(), + DefaultsPackage.getDefaultsPackageContent(buildOptions)); ExecutionTool executionTool = null; LoadingResult loadingResult = null; |