diff options
| author |  lpino <lpino@google.com> | 2018-06-21 08:35:40 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-21 08:37:10 -0700 |
| commit | 2b945323d2b4cf7dfdf988b9b04c4fb75e416206 (patch) | |
| tree | 37e5ba0b1e7277d6f386aa7f3853bbc2d7840c4e /src/main/java/com/google/devtools/build/lib/buildeventstream | |
| parent | cbd6f462f4dc8cbd305828abd7e5cd7152b266e0 (diff) | |
Fix NoSuchElementException when BuildEventArtifactUploaderMap has no elements.
When there are no uploaders in BuildEventArtifactUploaderMap then we should use the BuildEventArtifactUploader.LOCAL_FILES_UPLOADER as a fallback. Added some unit tests as regression tests for the underlying issue.
PiperOrigin-RevId: 201529578
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/buildeventstream')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/buildeventstream/BuildEventArtifactUploaderMap.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/buildeventstream/BuildEventArtifactUploaderMap.java b/src/main/java/com/google/devtools/build/lib/buildeventstream/BuildEventArtifactUploaderMap.java index 8987def882..e9f611ab9a 100644 --- a/src/main/java/com/google/devtools/build/lib/buildeventstream/BuildEventArtifactUploaderMap.java +++ b/src/main/java/com/google/devtools/build/lib/buildeventstream/BuildEventArtifactUploaderMap.java @@ -30,7 +30,7 @@ public class BuildEventArtifactUploaderMap { } public BuildEventArtifactUploader select(@Nullable String name) { - if (name == null) { + if (name == null && !uploaders.values().isEmpty()) { // TODO(b/110235226): We currently choose the strategy with alphabetically first strategy, // which happens to be backwards-compatible; we need to set // experimental_build_event_upload_strategy to appropriate default values instead, and then |