diff options
author | 2017-04-25 16:38:45 +0200 | |
---|---|---|
committer | 2017-04-25 20:38:12 +0200 | |
commit | 9e0308e0f7f18f752cf11350520313cf75c228e5 (patch) | |
tree | 3c243271c765bc7e193fe8fa3b36c09cc7f5de2f /src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java | |
parent | 941a4ca5e046f83dcedec51b456ad1f5058c8c08 (diff) |
Automated g4 rollback of commit d9fea57268ff01c001fbcbdc2bd057c86c362e6f.
*** Reason for rollback ***
Rollforward with fix for test flakiness. BEP transport closed
events are delivered via their own threadpool and thus might
not have been sent immediately. BuildEventStreamerTest#testSimpleStream
now waits for a bit until the event has been delivered. I ran the test
with --runs_per_test=1000 several times and had no further failures.
*** Original change description ***
Automated g4 rollback of commit 3d596d63f883fff56001ed7b2e5cf51dba45f082.
*** Reason for rollback ***
Made BuildEventStreamerTest#testSimpleStream 3% flaky based on --runs_per_test=1000.
RELNOTES: None
PiperOrigin-RevId: 154170833
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java b/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java index 6744df3ef6..3482cadd4b 100644 --- a/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java +++ b/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java @@ -18,6 +18,7 @@ import static com.google.common.base.Preconditions.checkNotNull; import static com.google.common.base.Preconditions.checkState; import com.google.common.annotations.VisibleForTesting; +import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.SettableFuture; import com.google.devtools.build.lib.buildeventstream.BuildEvent; import com.google.devtools.build.lib.buildeventstream.BuildEventTransport; @@ -27,7 +28,6 @@ import java.nio.channels.AsynchronousFileChannel; import java.nio.channels.CompletionHandler; import java.nio.file.Paths; import java.nio.file.StandardOpenOption; -import java.util.concurrent.Future; import java.util.logging.Level; import java.util.logging.Logger; @@ -87,7 +87,7 @@ abstract class FileTransport implements BuildEventTransport { } @Override - public synchronized Future<Void> close() { + public synchronized ListenableFuture<Void> close() { if (closing()) { return closeFuture; } |