aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/analysis
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2018-05-14 10:46:48 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-05-14 10:48:56 -0700
commitff723604b66b3a3909b8ed19439d556e95863a0a (patch)
treef418ff49951d04038b14f0762c477a9f4778e271 /src/main/java/com/google/devtools/build/lib/analysis
parentb5f13a3bceba6a760023e75e137f1b104c60cc16 (diff)
Only use fingerprint and checksum for equality and hashCode in BuildOptions$OptionsDiffForReconstruction. The fingerprint uniquely identifies the "baseline" BuildOptions object and the checksum uniquely identifies the "overlay", so we don't need to incorporate the rest of the data.
PiperOrigin-RevId: 196532013
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis')
-rw-r--r--src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java
index 87ed80b888..87c4244a13 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java
@@ -618,10 +618,7 @@ public final class BuildOptions implements Cloneable, Serializable {
return false;
}
OptionsDiffForReconstruction that = (OptionsDiffForReconstruction) o;
- return differingOptions.equals(that.differingOptions)
- && extraFirstFragmentClasses.equals(that.extraFirstFragmentClasses)
- && this.extraSecondFragments.equals(that.extraSecondFragments)
- && Arrays.equals(this.baseFingerprint, that.baseFingerprint)
+ return Arrays.equals(this.baseFingerprint, that.baseFingerprint)
&& this.checksum.equals(that.checksum);
}
@@ -635,12 +632,7 @@ public final class BuildOptions implements Cloneable, Serializable {
@Override
public int hashCode() {
- return Objects.hash(
- differingOptions,
- extraFirstFragmentClasses,
- extraSecondFragments,
- Arrays.hashCode(baseFingerprint),
- checksum);
+ return 31 * Arrays.hashCode(baseFingerprint) + checksum.hashCode();
}
}