Replaces JavaSerializableCodec with DynamicCodec as the default

* Skylark serialization was previously dropping location in error, which this fixes.
* Deletes a lot of codecs with fidelity issues (DynamicCodec has full fidelity).
* Deletes EnumRuntimeCodec which can now be replaced with the superior EnumCodec.
* This should eventually allow us to delete Serializable from all Blaze. The remaining blocker is NoSuchPackageExceptionCodec.

PiperOrigin-RevId: 191603929

1 files changed, 2 insertions, 10 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
index e6e6e9c637..5ad5007e96 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
@@ -71,7 +71,6 @@ import com.google.devtools.build.lib.packages.SkylarkProvider;
 import com.google.devtools.build.lib.packages.TargetUtils;
 import com.google.devtools.build.lib.packages.TestSize;
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
-import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec.VisibleForSerialization;
 import com.google.devtools.build.lib.skylarkinterface.Param;
 import com.google.devtools.build.lib.skylarkinterface.ParamType;
 import com.google.devtools.build.lib.skylarkinterface.SkylarkPrinter;
@@ -879,7 +878,6 @@ public class SkylarkRuleClassFunctions {
    *
    * <p>Exactly one of {@link #builder} or {@link #ruleClass} is null except inside {@link #export}.
    */
-  @AutoCodec
   public static final class SkylarkRuleFunction extends BaseFunction
       implements SkylarkExportable, RuleFunction {
     private RuleClass.Builder builder;
@@ -903,14 +901,8 @@ public class SkylarkRuleClassFunctions {
     }
 
     /** This is for post-export reconstruction for serialization. */
-    @VisibleForSerialization
-    @AutoCodec.Instantiator
-    SkylarkRuleFunction(
-        RuleClass ruleClass,
-        RuleClassType type,
-        Location definitionLocation,
-        Label skylarkLabel
-    ) {
+    private SkylarkRuleFunction(
+        RuleClass ruleClass, RuleClassType type, Location definitionLocation, Label skylarkLabel) {
       super("rule", FunctionSignature.KWARGS);
       Preconditions.checkNotNull(
           ruleClass,