diff options
| author |  ruperts <ruperts@google.com> | 2017-11-21 16:37:13 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2017-11-21 16:38:50 -0800 |
| commit | 7967f3387e63723bb36b974f83a816265d404c38 (patch) | |
| tree | 1533cc8bd2d63e1db9426d8795df902d104a3d1a /src/main/java/com/google/devtools/build/lib/analysis/test | |
| parent | a2a3d8ca6634abb8f8dc184edb4ea01543de8505 (diff) | |
Return SpawnResults using a List instead of a Set.
Currently we don't care about the list order of SpawnResults. However, we may care about the list order later. Also, if the equals() method for SpawnResults is ever changed then it may be problematic to return SpawnResults in a Set.
Aside: ActionResults use SpawnResults to calculate cumulative execution times for Actions, and may provide other metrics in future.
RELNOTES: None.
PiperOrigin-RevId: 176579460
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/test')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/test/TestActionContext.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/test/TestActionContext.java b/src/main/java/com/google/devtools/build/lib/analysis/test/TestActionContext.java index 44ae134d9d..885f42bbdf 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/test/TestActionContext.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/test/TestActionContext.java @@ -20,7 +20,7 @@ import com.google.devtools.build.lib.actions.SpawnResult; import com.google.devtools.build.lib.vfs.Path; import com.google.devtools.build.lib.view.test.TestStatus.TestResultData; import java.io.IOException; -import java.util.Set; +import java.util.List; /** * A context for the execution of test actions ({@link TestRunnerAction}). @@ -31,9 +31,9 @@ public interface TestActionContext extends ActionContext { * Executes the test command, directing standard out / err to {@code outErr}. The status of the * test should be communicated by posting a {@link TestResult} object to the eventbus. * - * @return a set of SpawnResults created during execution of the test command, if any + * @return a list of SpawnResults created during execution of the test command, if any */ - Set<SpawnResult> exec(TestRunnerAction action, ActionExecutionContext actionExecutionContext) + List<SpawnResult> exec(TestRunnerAction action, ActionExecutionContext actionExecutionContext) throws ExecException, InterruptedException; /** |