aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/analysis/skylark
diff options
context:
space:
mode:
authorGravatar cparsons <cparsons@google.com>2018-03-20 11:35:33 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-03-20 11:37:24 -0700
commitbe61041a69a614fd009fd613a70ac1ac8af5d507 (patch)
treec3c1bef8028dbcc743d5fd798de1df7e8d39e5e2 /src/main/java/com/google/devtools/build/lib/analysis/skylark
parent7ba9d764dfdea96da470f612d360824269fda132 (diff)
Force @SkylarkCallable Params with defaultValue = "None" to be noneable.
Previously, usage was fairly inconsistent. From now on, if the @Param is mandatory, use defaultValue = "" instead. RELNOTES: None. PiperOrigin-RevId: 189777905
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/skylark')
-rw-r--r--src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java
index b8f75f07dc..71a597f3cc 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java
@@ -517,7 +517,6 @@ public class SkylarkActionFactory implements SkylarkValue {
@ParamType(type = SkylarkList.class, generic1 = String.class),
@ParamType(type = Runtime.NoneType.class),
},
- defaultValue = "None",
named = true,
positional = false,
doc =