diff options
| author |  Dmitry Lomov <dslomov@google.com> | 2018-01-22 11:18:20 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-01-22 11:20:02 -0800 |
| commit | 2f80e5895fbcc4fc4102e57660cd631eba731b04 (patch) | |
| tree | 5b7d3f03515a2939f0750bc5e9b652f1ff49ad79 /src/main/java/com/google/devtools/build/lib/analysis/skylark | |
| parent | 32d359f4fbde6bfdcfa1beda64a87c407480ba76 (diff) | |
Only allow files created by the same rule as executable outputs of a rule.
Fixes #4170.
Change-Id: I308ee17eb769dcc6a94b90b1dd6cc2ccbe14e968
PiperOrigin-RevId: 182807196
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/skylark')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java index a40bacb549..d22857e84d 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java @@ -387,6 +387,14 @@ public final class SkylarkRuleConfiguredTargetUtil { defaultRunfiles = cast("default_runfiles", provider, Runfiles.class, loc); } else if (field.equals("executable")) { executable = cast("executable", provider, Artifact.class, loc); + if (!executable.getArtifactOwner().equals(context.getRuleContext().getOwner())) { + throw new EvalException( + loc, + String.format( + "'executable' provided by an executable rule '%s' should be created " + + "by the same rule.", + context.getRuleContext().getRule().getRuleClass())); + } } else if (provider .getProvider() .getKey() |