Refactor SkylarkProvider constructors and add tests

A new constructor is exposed for building an already-exported SkylarkProvider. The existing constructor no longer takes a name argument (since it was almost entirely ignored). The contract around the name arg for BaseFunction has been refined: it is null if the subclass provides its own naming mechanism.

RELNOTES: None
PiperOrigin-RevId: 179804491

1 files changed, 1 insertions, 4 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
index 1e7d5fe5dc..1879227a38 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
@@ -336,10 +336,7 @@ public class SkylarkRuleClassFunctions {
                 "Expected list of strings or dictionary of string -> string for 'fields'");
             fieldNames = dict.keySet();
           }
-          return new SkylarkProvider(
-              "<no name>", // name is set on export.
-              fieldNames,
-              location);
+          return SkylarkProvider.createUnexportedSchemaful(fieldNames, location);
         }
       };