aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
diff options
context:
space:
mode:
authorGravatar gregce <gregce@google.com>2018-01-29 15:01:20 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-29 15:02:53 -0800
commit207f4bdc9cc08e53592d0961867fe9b9bd82cc54 (patch)
treedd7966f1fcfb23355ee59c5bb73d0eaa58f99ed8 /src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
parent016a42bc5e6368fb34a52394e93058348c4ef1a3 (diff)
Remove Skylark ConfigurationTransition.DATA references.
PiperOrigin-RevId: 183733621
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java12
1 files changed, 8 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
index 5b2b6e30ec..7a83ac553b 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java
@@ -15,7 +15,6 @@
package com.google.devtools.build.lib.analysis.skylark;
import static com.google.devtools.build.lib.analysis.BaseRuleClasses.RUN_UNDER;
-import static com.google.devtools.build.lib.analysis.config.transitions.ConfigurationTransitionProxy.DATA;
import static com.google.devtools.build.lib.packages.Attribute.attr;
import static com.google.devtools.build.lib.packages.BuildType.LABEL;
import static com.google.devtools.build.lib.packages.BuildType.LABEL_LIST;
@@ -41,6 +40,7 @@ import com.google.devtools.build.lib.analysis.OutputGroupInfo;
import com.google.devtools.build.lib.analysis.TransitiveInfoCollection;
import com.google.devtools.build.lib.analysis.config.ConfigAwareRuleClassBuilder;
import com.google.devtools.build.lib.analysis.config.HostTransition;
+import com.google.devtools.build.lib.analysis.config.transitions.PatchTransition;
import com.google.devtools.build.lib.analysis.skylark.SkylarkAttr.Descriptor;
import com.google.devtools.build.lib.analysis.test.TestConfiguration;
import com.google.devtools.build.lib.cmdline.Label;
@@ -143,7 +143,8 @@ public class SkylarkRuleClassFunctions {
.build();
/** Parent rule class for test Skylark rules. */
- public static final RuleClass getTestBaseRule(String toolsRepository) {
+ public static final RuleClass getTestBaseRule(String toolsRepository,
+ PatchTransition lipoDataTransition) {
return new RuleClass.Builder("$test_base_rule", RuleClassType.ABSTRACT, true, baseRule)
.requiresConfigurationFragments(TestConfiguration.class)
.add(
@@ -200,7 +201,9 @@ public class SkylarkRuleClassFunctions {
.cfg(HostTransition.INSTANCE)
.value(labelCache.getUnchecked("//tools/defaults:coverage_report_generator"))
.singleArtifact())
- .add(attr(":run_under", LABEL).cfg(DATA).value(RUN_UNDER))
+ .add(attr(":run_under", LABEL)
+ .cfg(lipoDataTransition)
+ .value(RUN_UNDER))
.build();
}
@@ -496,7 +499,8 @@ public class SkylarkRuleClassFunctions {
RuleClassType type = test ? RuleClassType.TEST : RuleClassType.NORMAL;
RuleClass parent =
test
- ? getTestBaseRule(SkylarkUtils.getToolsRepository(funcallEnv))
+ ? getTestBaseRule(SkylarkUtils.getToolsRepository(funcallEnv),
+ (PatchTransition) SkylarkUtils.getLipoDataTransition(funcallEnv))
: (executable ? binaryBaseRule : baseRule);
// We'll set the name later, pass the empty string for now.