Make the builtins registry thread-safe

It was previously assumed that safety wasn't needed because

  1) all builtins should be registered in static initializer blocks, and
  2) all retrievals should occur during Skylark evaluation, after static initialization completes.

It turns out these assumptions aren't actually true (Who would've thunk it!). SkylarkActionFactory has been observed to be initialized as late as analysis time, and retrievals occur as early as constructing a PackageFactory (when scanning the native module). The failure mode is particularly ugly: Random Skylark method lookups will fail non-deterministically.

This change guards against this by making the builtins registry implement a form of freezing. Before freezing, reads and writes are allowed and are synchronized. After freezing, only reads are allowed and they are unsynchronized for performance. BlazeRuntime is responsible for flipping the bit, and for ensuring classes like SkylarkActionFactory run their initialization by that point. Unit tests don't need to worry, since they just stay unfrozen and synchronized throughout.

RELNOTES: None
PiperOrigin-RevId: 188080136

1 files changed, 12 insertions, 0 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java
index e14bfc0046..914be9b43f 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java
@@ -1142,6 +1142,10 @@ public class SkylarkActionFactory implements SkylarkValue {
     static {
       SkylarkSignatureProcessor.configureSkylarkFunctions(Args.class);
     }
+
+    /** No-op method that can be called to ensure the above static initializer runs. */
+    public static void forceStaticInitialization() {
+    }
   }
 
   @SkylarkSignature(
@@ -1185,4 +1189,12 @@ public class SkylarkActionFactory implements SkylarkValue {
   static {
     SkylarkSignatureProcessor.configureSkylarkFunctions(SkylarkActionFactory.class);
   }
+
+  /**
+   * No-op method that can be called to ensure the above static initializer runs, as well as the
+   * initializer for nested classes.
+   */
+  public static void forceStaticInitialization() {
+    Args.forceStaticInitialization();
+  }
 }