diff options
| author |  tomlu <tomlu@google.com> | 2017-07-10 15:53:57 +0200 |
|---|---|---|
| committer |  László Csomor <laszlocsomor@google.com> | 2017-07-10 17:44:45 +0200 |
| commit | 6426c01073a85c5929f7664302d02f651e243b4f (patch) | |
| tree | 4ec69d7a16a237681bcdfb73b380a3f42647feef /src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java | |
| parent | 730594414cf3e45305a945c055484cc69c96f6bb (diff) | |
Fix memory regression from CL/160891204.
Java compile actions create unnecessary wrapper objects around a shared constant object. We can share the ActionEnviroment between these actions.
In the general spawn case there will be a lot of empty action environments. Make sure that these are shared too.
RELNOTES: None
PiperOrigin-RevId: 161389056
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java b/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java index 0cf88d3074..8ca651b757 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java @@ -648,7 +648,7 @@ public class SpawnAction extends AbstractAction implements ExecutionInfoSpecifie if (useDefaultShellEnvironment) { env = Preconditions.checkNotNull(configEnv); } else { - env = new ActionEnvironment(this.environment); + env = ActionEnvironment.create(this.environment); } if (disableSandboxing) { |