aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
diff options
context:
space:
mode:
authorGravatar dannark <dannark@google.com>2018-03-04 06:47:47 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-03-04 06:49:19 -0800
commit96145511b34a2d7be834e3eb05927674e875c813 (patch)
tree07a7467144b02cdf2c487797daa2b99172d44833 /src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
parent76de1ad3af6297cbc7c34054dd4340e02750a712 (diff)
Automated rollback of commit eee53d3a33dde441f7e7adaecde81ef2d3db7c1b.
*** Reason for rollback *** breaks Blaze_CorpTest *** Original change description *** @AutoCodec ConfiguredTargetValue. PiperOrigin-RevId: 187783702
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java27
1 files changed, 12 insertions, 15 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java b/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
index a2ba6867df..2fc824a10f 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
@@ -24,8 +24,6 @@ import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.analysis.actions.AbstractFileWriteAction;
import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable;
import com.google.devtools.build.lib.events.EventHandler;
-import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
-import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec.VisibleForSerialization;
import com.google.devtools.build.lib.util.Fingerprint;
import com.google.devtools.build.lib.vfs.PathFragment;
import java.io.BufferedWriter;
@@ -42,15 +40,15 @@ import java.util.Map;
import javax.annotation.Nullable;
/**
- * Action to create a manifest of input files for processing by a subsequent build step (e.g.
- * runfiles symlinking or archive building).
+ * Action to create a manifest of input files for processing by a subsequent
+ * build step (e.g. runfiles symlinking or archive building).
*
- * <p>The manifest's format is specifiable by {@link ManifestType}, in accordance with the needs of
- * the calling functionality.
+ * <p>The manifest's format is specifiable by {@link ManifestType}, in
+ * accordance with the needs of the calling functionality.
*
- * <p>Note that this action carefully avoids building the manifest content in memory.
+ * <p>Note that this action carefully avoids building the manifest content in
+ * memory.
*/
-@AutoCodec
@Immutable // if all ManifestWriter implementations are immutable
public final class SourceManifestAction extends AbstractFileWriteAction {
@@ -95,18 +93,17 @@ public final class SourceManifestAction extends AbstractFileWriteAction {
private final Runfiles runfiles;
/**
- * Creates a new AbstractSourceManifestAction instance using latin1 encoding to write the manifest
- * file and with a specified root path for manifest entries.
+ * Creates a new AbstractSourceManifestAction instance using latin1 encoding
+ * to write the manifest file and with a specified root path for manifest entries.
*
* @param manifestWriter the strategy to use to write manifest entries
* @param owner the action owner
- * @param primaryOutput the file to which to write the manifest
+ * @param output the file to which to write the manifest
* @param runfiles runfiles
*/
- @VisibleForSerialization
- SourceManifestAction(
- ManifestWriter manifestWriter, ActionOwner owner, Artifact primaryOutput, Runfiles runfiles) {
- super(owner, getDependencies(runfiles), primaryOutput, false);
+ private SourceManifestAction(ManifestWriter manifestWriter, ActionOwner owner, Artifact output,
+ Runfiles runfiles) {
+ super(owner, getDependencies(runfiles), output, false);
this.manifestWriter = manifestWriter;
this.runfiles = runfiles;
}