Reimplement the configuration sanity check as a per-fragment check.

This is conceptually better (because each fragment should be
self-contained), and gives us better performance, as we no longer need to
load all explicit labels.

--
MOS_MIGRATED_REVID=118674470

1 files changed, 1 insertions, 4 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/ConfigurationCollectionFactory.java b/src/main/java/com/google/devtools/build/lib/analysis/ConfigurationCollectionFactory.java
index 3e3b35f7b3..77c51d9e44 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/ConfigurationCollectionFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/ConfigurationCollectionFactory.java
@@ -39,8 +39,6 @@ public interface ConfigurationCollectionFactory {
    * @param loadedPackageProvider the package provider
    * @param buildOptions top-level build options representing the command-line
    * @param errorEventListener the event listener for errors
-   * @param performSanityCheck flag to signal about performing sanity check. Can be false only for
-   * tests in skyframe. Legacy mode uses loadedPackageProvider == null condition for this.
    * @return the top-level configuration
    * @throws InvalidConfigurationException
    */
@@ -50,8 +48,7 @@ public interface ConfigurationCollectionFactory {
       Cache<String, BuildConfiguration> cache,
       PackageProviderForConfigurations loadedPackageProvider,
       BuildOptions buildOptions,
-      EventHandler errorEventListener,
-      boolean performSanityCheck) throws InvalidConfigurationException;
+      EventHandler errorEventListener) throws InvalidConfigurationException;
 
   /**
    * Returns the module the given configuration should use for choosing dynamic transitions.