Make --experimental_interleave_loading_and_analysis a no-op.

This is now enabled by default, and this change removes the code path where
it's disabled.

Remove a few tests that were testing the removed code, and rewrite some others
that still seem useful. We still drop configured targets on configuration
changes, so we use that to check that things are dropped from Skyframe.

--
MOS_MIGRATED_REVID=132226208

1 files changed, 9 insertions, 7 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
index 0fbaebb7d2..e070680d1a 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
@@ -184,13 +184,6 @@ public class BuildView {
             help = "Only schedules extra_actions for top level targets.")
     public boolean extraActionTopLevelOnly;
 
-    @Option(name = "experimental_interleave_loading_and_analysis",
-            defaultValue = "true",
-            category = "experimental",
-            help = "Interleave loading and analysis phases, so that one target may be analyzed at"
-                + " the same time as an unrelated target is loaded.")
-    public boolean interleaveLoadingAndAnalysis;
-
     @Option(name = "version_window_for_dirty_node_gc",
             defaultValue = "0",
             category = "undocumented",
@@ -198,6 +191,15 @@ public class BuildView {
                 + " from the graph upon the next update. Values must be non-negative long integers,"
                 + " or -1 indicating the maximum possible window.")
     public long versionWindowForDirtyNodeGc;
+
+    @Deprecated
+    @Option(
+      name = "experimental_interleave_loading_and_analysis",
+      defaultValue = "true",
+      category = "experimental",
+      help = "No-op."
+    )
+    public boolean interleaveLoadingAndAnalysis;
   }
 
   private static Logger LOG = Logger.getLogger(BuildView.class.getName());