diff options
| author |  Carmi Grushko <carmi@google.com> | 2016-10-01 03:49:54 +0000 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2016-10-04 08:53:39 +0000 |
| commit | f6cbb637d1dcaa04e2c55dc2775a0a2290056234 (patch) | |
| tree | 3d3f11d0b7bded4b6b649f589d6437bca6841e46 /src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java | |
| parent | 0bddbc7b3c1878a1ff94911409935d3cd32e974c (diff) | |
Rollback of commit 3c0d64886d2f7f6b2015780f1628b1391c320d0f.
*** Reason for rollback ***
Blaze with this CL breaks ~all targets: "There is already a built-in attribute 'name' which cannot be overridden."
*** Original change description ***
Proper error messages when built-in rule attributes are overridden #1811
--
MOS_MIGRATED_REVID=134857179
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java index eb49821885..48cb299a74 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java @@ -161,8 +161,6 @@ public class BaseRuleClasses { */ public static RuleClass.Builder commonCoreAndSkylarkAttributes(RuleClass.Builder builder) { return builder - .add(attr("name", STRING) - .nonconfigurable("Rule name")) // The visibility attribute is special: it is a nodep label, and loading the // necessary package groups is handled by {@link LabelVisitor#visitTargetVisibility}. // Package groups always have the null configuration so that they are not duplicated |