diff options
| author |  Vladimir Moskva <vladmos@google.com> | 2016-10-05 16:36:49 +0000 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2016-10-05 19:41:48 +0000 |
| commit | da57492887aa13b2bad2af2b0f9de25b1c87b446 (patch) | |
| tree | 4c610c83a27ac55e44d0d26184a90ffba3073678 /src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java | |
| parent | 39bb51a47e97f8d3771a282d5a9384fe041a506b (diff) | |
Proper error messages when built-in rule attributes are overridden #1811
--
MOS_MIGRATED_REVID=135241715
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java index 48cb299a74..eb49821885 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java @@ -161,6 +161,8 @@ public class BaseRuleClasses { */ public static RuleClass.Builder commonCoreAndSkylarkAttributes(RuleClass.Builder builder) { return builder + .add(attr("name", STRING) + .nonconfigurable("Rule name")) // The visibility attribute is special: it is a nodep label, and loading the // necessary package groups is handled by {@link LabelVisitor#visitTargetVisibility}. // Package groups always have the null configuration so that they are not duplicated |