Make compatible_with / restricted_to nonconfigurable.

As of 18c277f, we have special logic for mixing
selects and constraints. With that logic, a multiplaform
libray declares all environments it supports across
all select paths, then each path supports some subset of
those environments.

With this approach, there's no need for
compatible_with = select(). So we'd like to disallow
that pattern (and all its downsides) in preference for
what 18c277f allows.

--
MOS_MIGRATED_REVID=121294433

1 files changed, 6 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java
index 32307a5e70..031325e121 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java
@@ -224,11 +224,15 @@ public class BaseRuleClasses {
         .add(attr(RuleClass.COMPATIBLE_ENVIRONMENT_ATTR, LABEL_LIST)
             .allowedRuleClasses(EnvironmentRule.RULE_NAME)
             .cfg(Attribute.ConfigurationTransition.HOST)
-            .allowedFileTypes(FileTypeSet.NO_FILE))
+            .allowedFileTypes(FileTypeSet.NO_FILE)
+            .nonconfigurable("special logic for constraints and select: see ConstraintSemantics")
+        )
         .add(attr(RuleClass.RESTRICTED_ENVIRONMENT_ATTR, LABEL_LIST)
             .allowedRuleClasses(EnvironmentRule.RULE_NAME)
             .cfg(Attribute.ConfigurationTransition.HOST)
-            .allowedFileTypes(FileTypeSet.NO_FILE));
+            .allowedFileTypes(FileTypeSet.NO_FILE)
+            .nonconfigurable("special logic for constraints and select: see ConstraintSemantics")
+        );
   }
 
   /**