aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java
diff options
context:
space:
mode:
authorGravatar aehlig <aehlig@google.com>2017-04-04 15:03:23 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2017-04-04 18:39:53 +0200
commit617bb896dc5d2b815449459e991c577237d7a7fc (patch)
treee25a4bfe6e925ad2cff32c71447af412a77faf2e /src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java
parent0297702d9533142e6c326660f913899d25b89b5d (diff)
BEP: provide events a generic converter class
Change the BuildEvent interface to accept a generic class of converters. In this way, we won't have to change it again in the future, once more converters are needed. In fact, a new converter is needed right now (will be added in a follow-up patch) to allow build events to know the name of named artifact groups already reported in the stream. Change-Id: Ibb32ea5fff361e21bcf2d34818d8351a1da7a2e3 PiperOrigin-RevId: 152131870
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java b/src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java
index 0bdbd9e71e..7c1b02cfbe 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/AspectCompleteEvent.java
@@ -18,6 +18,7 @@ import com.google.common.collect.Iterables;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.analysis.TopLevelArtifactHelper.ArtifactsInOutputGroup;
import com.google.devtools.build.lib.analysis.TopLevelArtifactHelper.ArtifactsToBuild;
+import com.google.devtools.build.lib.buildeventstream.BuildEventConverters;
import com.google.devtools.build.lib.buildeventstream.BuildEventId;
import com.google.devtools.build.lib.buildeventstream.BuildEventStreamProtos;
import com.google.devtools.build.lib.buildeventstream.BuildEventStreamProtos.File;
@@ -104,7 +105,8 @@ public class AspectCompleteEvent implements SkyValue, BuildEventWithOrderConstra
}
@Override
- public BuildEventStreamProtos.BuildEvent asStreamProto(PathConverter pathConverter) {
+ public BuildEventStreamProtos.BuildEvent asStreamProto(BuildEventConverters converters) {
+ PathConverter pathConverter = converters.pathConverter();
BuildEventStreamProtos.TargetComplete.Builder builder =
BuildEventStreamProtos.TargetComplete.newBuilder();
builder.setSuccess(!failed());